-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CI): Move CI to Github Actions #71
Merged
Merged
+119
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actions start pointing at develop as our default branch to match reality
SAST is already running via the settings on this repo
also turn off our testing branch push runs
samoehlert
had a problem deploying
to
github-pages
November 12, 2024 05:04 — with
GitHub Actions
Failure
grigorescu
requested changes
Nov 13, 2024
works in conjunction with the if on the last step to run always, excpet only publish the docs on the main branch
samoehlert
had a problem deploying
to
github-pages
November 14, 2024 03:21 — with
GitHub Actions
Failure
we can always skip using a flag in our commit messages if needed https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/skipping-workflow-runs
samoehlert
had a problem deploying
to
github-pages
November 14, 2024 03:27 — with
GitHub Actions
Failure
samoehlert
had a problem deploying
to
github-pages
November 14, 2024 03:31 — with
GitHub Actions
Failure
Minimum allowed coverage is Generated by 🐒 cobertura-action against 413e2dc |
grigorescu
previously approved these changes
Nov 14, 2024
samoehlert
had a problem deploying
to
github-pages
November 14, 2024 16:30 — with
GitHub Actions
Failure
samoehlert
had a problem deploying
to
github-pages
November 14, 2024 16:46 — with
GitHub Actions
Failure
crankynetman
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #50
Moving to Github Actions allows for better external collaboration as well as just a pure speed increase. This also means we can remove the dependency on Gitlab CI. We did remove a few of the built in processes from Gitlab CI file, but that's because we could turn on things in the settings directly (secret scanning and dependency scanning as well as Code Quality/SAST).